Update custom granularity spec #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
tlento
reviewed
Aug 29, 2024
| @@ -28,7 +28,7 @@ def primary_column(self) -> TimeSpinePrimaryColumn: | |||
|
|
|||
| @property | |||
| @abstractmethod | |||
| def custom_granularity_columns(self) -> Sequence[TimeSpineCustomGranularityColumn]: | |||
| def custom_granularities(self) -> Sequence[TimeSpineCustomGranularityColumn]: | |||
There was a problem hiding this comment.
Don't we need to add column_name to the protocol defined on line 52?
There was a problem hiding this comment.
Oops you're right!
WilliamDee
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename
custom_granularity_columns->custom_granularitiesand addcolumn_nameproperty. This matches the newly-approved spec that will be added to core.This would be a breaking change, but since this isn't used anywhere yet, nothing will break.
Checklist
changie newto create a changelog entry